[
https://issues.apache.org/jira/browse/TS-4532?focusedWorklogId=28128&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28128
]
ASF GitHub Bot logged work on TS-4532:
--------------------------------------
Author: ASF GitHub Bot
Created on: 05/Sep/16 16:18
Start Date: 05/Sep/16 16:18
Worklog Time Spent: 10m
Work Description: Github user SolidWallOfCode commented on a diff in the
pull request:
https://github.com/apache/trafficserver/pull/965#discussion_r77541520
--- Diff: iocore/eventsystem/UnixEThread.cc ---
@@ -149,10 +149,10 @@ EThread::process_event(Event *e, int calling_code)
ink_assert(!e->in_the_priority_queue);
ink_assert(c_temp == e->continuation);
MUTEX_RELEASE(lock);
- if (e->period) {
+ if (e->period.count()) {
if (!e->in_the_prot_queue && !e->in_the_priority_queue) {
- if (e->period < 0)
- e->timeout_at = e->period;
+ if (e->period.count() < 0)
--- End diff --
Or ``e->period < e->period.zero()`` ?
Issue Time Tracking
-------------------
Worklog Id: (was: 28128)
Time Spent: 2h 10m (was: 2h)
> Static type checking for time units
> -----------------------------------
>
> Key: TS-4532
> URL: https://issues.apache.org/jira/browse/TS-4532
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
> Reporter: James Peach
> Assignee: Alan M. Carroll
> Fix For: 7.0.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Since the various time units {{ink_time_t}}, {{time_t}}, {{ink_hrtime}} are
> all typedefs of C integral types, it is very hard to ensure that units are
> being converted and compared correctly.
> Consider wrapping these in trivial classes as part of making the time APIs
> more straightforward. Alternatively, if we move to {{C++11}} investigate
> {{std::chrono}} for this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
