[
https://issues.apache.org/jira/browse/TS-4820?focusedWorklogId=28249&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28249
]
ASF GitHub Bot logged work on TS-4820:
--------------------------------------
Author: ASF GitHub Bot
Created on: 07/Sep/16 00:41
Start Date: 07/Sep/16 00:41
Worklog Time Spent: 10m
Work Description: GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/973
TS-4820: ParseRules::ink_tolower_buffer seems to be broken
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich/trafficserver ts-4820
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/973.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #973
----
commit df841f398ef4a174b7b3d00218fc4fd71a202a54
Author: Susan Hinrichs <[email protected]>
Date: 2016-09-07T00:40:17Z
TS-4820: ParseRules::ink_tolower_buffer seems to be broken
----
Issue Time Tracking
-------------------
Worklog Id: (was: 28249)
Time Spent: 10m
Remaining Estimate: 0h
> ParseRules::ink_tolower_buffer seems to be broken
> -------------------------------------------------
>
> Key: TS-4820
> URL: https://issues.apache.org/jira/browse/TS-4820
> Project: Traffic Server
> Issue Type: Bug
> Reporter: Susan Hinrichs
> Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This function doesn't seem to be used.
> It tries to be clever about unrolling the character copy loop to do word
> aligned assignments. However, its calculation about the number of characters
> to assign to get the pointer to be word aligned is wrong (fpad).
> The assignment in the code is
> {code}
> uintptr_t fpad = 4 - ((uintptr_t)ptr & 3);
> {code}
> I think it should be
> {code}
> uintptr_t fpad = ((uintptr_t)ptr & 3);
> {code}
> I tried using this function while addressing the lower case cert name lookup
> bug, but it didn't work. It only copied the first 8 of 14 characters.
> I grepped the code base and it seems that this function is not used anywhere.
> I would suggest just removing the ink_tolower_buffer function. I think
> compilers are clever enough these days to do the unrolling if it makes sense.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
