[
https://issues.apache.org/jira/browse/TS-4657?focusedWorklogId=28304&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28304
]
ASF GitHub Bot logged work on TS-4657:
--------------------------------------
Author: ASF GitHub Bot
Created on: 07/Sep/16 16:59
Start Date: 07/Sep/16 16:59
Worklog Time Spent: 10m
Work Description: Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/977
Looks good, but fails on FreeBSD for some reason:
{code}
../../../iocore/net/SSLUtils.cc:384:27: error: use of undeclared identifier
'TS_SSL_CERT_EVENT'; did you mean 'TS_SSL_CERT_HOOK'?
if (!netvc->calledHooks(TS_SSL_CERT_EVENT)) {
^~~~~~~~~~~~~~~~~
TS_SSL_CERT_HOOK
../../lib/ts/apidefs.h:290:3: note: 'TS_SSL_CERT_HOOK' declared here
TS_SSL_CERT_HOOK = TS_SSL_SNI_HOOK,
^
../../../iocore/net/SSLUtils.cc:384:27: error: cannot initialize a
parameter of type 'TSEvent' with an rvalue of type 'TSHttpHookID'
if (!netvc->calledHooks(TS_SSL_CERT_EVENT)) {
^~~~~~~~~~~~~~~~~
../../../iocore/net/P_SSLNetVConnection.h:221:41: note: passing argument to
parameter here
bool calledHooks(TSEvent /* eventId */) const { return
(this->sslHandshakeHookState != HANDSHAKE_HOOKS_PRE); }
^
{code}
Issue Time Tracking
-------------------
Worklog Id: (was: 28304)
Time Spent: 40m (was: 0.5h)
> SNI hook sends hook ID for events
> ---------------------------------
>
> Key: TS-4657
> URL: https://issues.apache.org/jira/browse/TS-4657
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: James Peach
> Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> If you use the {{TS_SSL_SNI_HOOK}} hook, it will send {{TS_SSL_SNI_HOOK}}
> values as the event. {{TS_SSL_SNI_HOOK}} is not a valid {{TSEvent}} value.
> It is also weird that {{TS_SSL_SNI_HOOK}} and {{TS_SSL_CERT_HOOK}} have the
> same value. One of these ought to be redundant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
