[
https://issues.apache.org/jira/browse/TS-1882?focusedWorklogId=28334&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28334
]
ASF GitHub Bot logged work on TS-1882:
--------------------------------------
Author: ASF GitHub Bot
Created on: 07/Sep/16 18:05
Start Date: 07/Sep/16 18:05
Worklog Time Spent: 10m
Work Description: Github user SolidWallOfCode commented on a diff in the
pull request:
https://github.com/apache/trafficserver/pull/971#discussion_r77874593
--- Diff: proxy/Main.cc ---
@@ -476,6 +476,18 @@ check_config_directories(void)
}
}
+namespace {
+ // Values with names that have this prefix are exempted from being
considered "unrecognized".
+ const char PLUGIN_CONFIG_RECORD_PREFIX[] = "proxy.config.plugin.";
--- End diff --
This is the root of the problem in that if arbitrary config names can be
used by plugins, you can't do validity checks. The consensus at the bug scrub
was it was reasonable to restrict plugin configuration values to that subtree.
I could move the check after plugin initialization so that if a plugin does
call {{TSMgmtStringCreate}} it doesn't generate a warning.
Issue Time Tracking
-------------------
Worklog Id: (was: 28334)
Time Spent: 1h (was: 50m)
> ATS doesn't warn about unknown config items
> -------------------------------------------
>
> Key: TS-1882
> URL: https://issues.apache.org/jira/browse/TS-1882
> Project: Traffic Server
> Issue Type: Bug
> Components: Configuration
> Reporter: Ebrahim Mohammadi
> Assignee: Alan M. Carroll
> Fix For: 7.0.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Apache Traffic Server doesn't warn about unknown configuration file items. It
> can cause huge confusions, specially in case of trying to get features of a
> newer version to work on an older installed version by mistake, as I found
> out the hard way!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
