[ 
https://issues.apache.org/jira/browse/TS-4821?focusedWorklogId=28356&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28356
 ]

ASF GitHub Bot logged work on TS-4821:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Sep/16 20:45
            Start Date: 07/Sep/16 20:45
    Worklog Time Spent: 10m 
      Work Description: Github user jpeach commented on a diff in the pull 
request:

    https://github.com/apache/trafficserver/pull/981#discussion_r77900285
  
    --- Diff: build/hwloc.m4 ---
    @@ -0,0 +1,105 @@
    +dnl -------------------------------------------------------- -*- autoconf 
-*-
    +dnl Licensed to the Apache Software Foundation (ASF) under one or more
    +dnl contributor license agreements.  See the NOTICE file distributed with
    +dnl this work for additional information regarding copyright ownership.
    +dnl The ASF licenses this file to You under the Apache License, Version 2.0
    +dnl (the "License"); you may not use this file except in compliance with
    +dnl the License.  You may obtain a copy of the License at
    +dnl
    +dnl     http://www.apache.org/licenses/LICENSE-2.0
    +dnl
    +dnl Unless required by applicable law or agreed to in writing, software
    +dnl distributed under the License is distributed on an "AS IS" BASIS,
    +dnl WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
    +dnl See the License for the specific language governing permissions and
    +dnl limitations under the License.
    +
    +dnl
    +dnl hwloc.m4: Trafficserver's hwloc autoconf macros
    +dnl
    +
    +dnl
    +dnl TS_CHECK_HWLOC: look for hwloc libraries and headers
    +dnl
    +AC_DEFUN([TS_CHECK_HWLOC], [
    --- End diff --
    
    Normally the macro would just do the check, taking arguments of what to do 
if the check succeeded or failed. The caller would be responsible for throwing 
the error.


Issue Time Tracking
-------------------

    Worklog Id:     (was: 28356)
    Time Spent: 1h 10m  (was: 1h)

> Make hwloc a required dependency
> --------------------------------
>
>                 Key: TS-4821
>                 URL: https://issues.apache.org/jira/browse/TS-4821
>             Project: Traffic Server
>          Issue Type: Task
>          Components: Build
>            Reporter: Phil Sorber
>            Assignee: Phil Sorber
>             Fix For: 7.0.0
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> hwloc is available on every platform we support. We do a lot of dances in the 
> code to make this optional, and we should probably just require it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to