Github user jpeach commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/991#discussion_r78074461
  
    --- Diff: proxy/Main.cc ---
    @@ -908,7 +908,7 @@ check_fd_limit()
       if (fds_throttle > fds_limit + THROTTLE_FD_HEADROOM) {
         int new_fds_throttle = fds_limit - THROTTLE_FD_HEADROOM;
         if (new_fds_throttle < 1) {
    -      MachineFatal("too few file descritors (%d) available", fds_limit);
    +      ink_abort("too few file descritors (%d) available", fds_limit);
    --- End diff --
    
    ``Fatal`` would be better than ``ink_abort`` since it formats its message 
to the right log sinks before actually aborting.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to