[
https://issues.apache.org/jira/browse/TS-4731?focusedWorklogId=28522&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28522
]
ASF GitHub Bot logged work on TS-4731:
--------------------------------------
Author: ASF GitHub Bot
Created on: 08/Sep/16 21:20
Start Date: 08/Sep/16 21:20
Worklog Time Spent: 10m
Work Description: Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/995
Whomever is reviewing: Please make sure I got all the conditionals right,
with the correct boolean logic.
Issue Time Tracking
-------------------
Worklog Id: (was: 28522)
Time Spent: 20m (was: 10m)
> Change return type for TSHttpTxnIsInternal and TSHttpSsnIsInternal
> ------------------------------------------------------------------
>
> Key: TS-4731
> URL: https://issues.apache.org/jira/browse/TS-4731
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Labels: incompatible
> Fix For: 7.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I'd like to propose that we modify these two APIs from:
> {code}
> tsapi TSReturnCode TSHttpTxnIsInternal(TSHttpTxn txnp);
> tsapi TSReturnCode TSHttpSsnIsInternal(TSHttpSsn snap);
> {code}
> to be
> {code}
> tsapi int TSHttpTxnIsInternal(TSHttpTxn txnp);
> tsapi int TSHttpSsnIsInternal(TSHttpSsn snap);
> {code}
> This is more inline with our current standards of using "int" as a boolean
> type. This is for example the prototype in TSVConnIsSsl() as well as in e.g.
> TSHttpTxnDebugSet(TSHttpTxn txnp, int on).
> This is an incompatible change though.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
