Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/996
My comments from [TS-4834](https://issues.apache.org/jira/browse/TS-4834) ..
>I think the nomenclature should mirror the existing metrics which
typically don't include "count" in the names. Especially since the count of bad
disks (gauge) does not have the same semantics as the count of disk errors
(counter).
Looking at the code I think the bad disk metric is a counter not a gauge.
> Is "disk" the right nomenclature, or would "span" be more accurate?
How feasible is it to have separate metrics for read and write errors? Does
it make sense to also have metrics for disk read and write operations, or are
system tools sufficient for that?
If you have a count of bad disks, does it make sense to have other disk
counts? ie. good disks, offline disks, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
