[
https://issues.apache.org/jira/browse/TS-4806?focusedWorklogId=28716&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28716
]
ASF GitHub Bot logged work on TS-4806:
--------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/16 11:08
Start Date: 10/Sep/16 11:08
Worklog Time Spent: 10m
Work Description: Github user gtenev commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/956#discussion_r78275728
--- Diff: iocore/eventsystem/UnixEventProcessor.cc ---
@@ -129,34 +197,58 @@ EventProcessor::start(int n_event_threads, size_t
stacksize)
obj_name = (char *)"Machine";
}
+ // How many of the above `obj_type` do we have in our topology?
obj_count = hwloc_get_nbobjs_by_type(ink_get_topology(), obj_type);
Debug("iocore_thread", "Affinity: %d %ss: %d PU: %d", affinity,
obj_name, obj_count, ink_number_of_processors());
#endif
for (i = 0; i < n_ethreads; i++) {
ink_thread tid;
- if (i > 0) {
- snprintf(thr_name, MAX_THREAD_NAME_LENGTH, "[ET_NET %d]", i);
- tid = all_ethreads[i]->start(thr_name, stacksize);
- } else {
- tid = ink_thread_self();
- }
+
#if TS_USE_HWLOC
if (obj_count > 0) {
+ // Get our `obj` instance with index based on the thread number we
are on.
obj = hwloc_get_obj_by_type(ink_get_topology(), obj_type, i %
obj_count);
--- End diff --
We could defensively check/handle ``NULL`` to "protect" ``obj->cpuset``
later.
Issue Time Tracking
-------------------
Worklog Id: (was: 28716)
Time Spent: 4h (was: 3h 50m)
> Fix up event processor thread stacks
> ------------------------------------
>
> Key: TS-4806
> URL: https://issues.apache.org/jira/browse/TS-4806
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
> Reporter: Phil Sorber
> Assignee: Phil Sorber
> Fix For: 7.0.0
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Fix event processor to create stacks on the appropriate numa node and with
> the appropriate page size. Also, stop using the main thread as ET_NET 0 since
> we can't control any of these aspects of it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
