[
https://issues.apache.org/jira/browse/TS-3216?focusedWorklogId=28762&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28762
]
ASF GitHub Bot logged work on TS-3216:
--------------------------------------
Author: ASF GitHub Bot
Created on: 12/Sep/16 02:31
Start Date: 12/Sep/16 02:31
Worklog Time Spent: 10m
Work Description: Github user masaori335 commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/990#discussion_r78309860
--- Diff: iocore/net/SSLUtils.cc ---
@@ -1866,10 +1934,17 @@ ssl_store_ssl_context(const SSLConfigParams
*params, SSLCertLookup *lookup, cons
keyblock = ssl_context_enable_tickets(ctx, NULL);
}
+ // Generate HPKP header if hpkp is enabled.
+ if (sslMultCertSettings.hpkp_enabled >= 0 ?
sslMultCertSettings.hpkp_enabled : params->hpkp_enabled) {
--- End diff --
It is possible:) `sslMultCertSettings.hpkp_enabled` is initialized by `-1`,
so settings in ssl_multicert.config (`0` or `1`) is preceded if they're
written. This is expected behavior, right?
Issue Time Tracking
-------------------
Worklog Id: (was: 28762)
Time Spent: 1h 50m (was: 1h 40m)
> Add HPKP (Public Key Pinning Extension for HTTP) support
> --------------------------------------------------------
>
> Key: TS-3216
> URL: https://issues.apache.org/jira/browse/TS-3216
> Project: Traffic Server
> Issue Type: New Feature
> Components: SSL
> Reporter: Masaori Koshiba
> Assignee: Masaori Koshiba
> Labels: review
> Fix For: 7.0.0
>
> Attachments: hpkp-001.patch, hpkp-002.patch, hpkp-003.patch
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Add "Public Key Pinning Extension for HTTP" Support in Traffic Server.
> RFC 7469 Public Key Pinning Extension for HTTP
> - https://tools.ietf.org/html/rfc7469
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
