Github user persiaAziz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1008#discussion_r78407691
--- Diff: iocore/net/SSLUtils.cc ---
@@ -2055,9 +2055,11 @@ SSLParseCertificateConfiguration(const
SSLConfigParams *params, SSLCertLookup *l
// load the global ticket key for later use
REC_ReadConfigStringAlloc(ticket_key_filename,
"proxy.config.ssl.server.ticket_key.filename");
- ats_scoped_str
ticket_key_path(Layout::relative_to(params->serverCertPathOnly,
ticket_key_filename));
- global_default_keyblock = ssl_create_ticket_keyblock(ticket_key_path);
// this function just returns a keyblock
-
+ if (ticket_key_filename != NULL) {
+ ats_scoped_str
ticket_key_path(Layout::relative_to(params->serverCertPathOnly,
ticket_key_filename));
+ global_default_keyblock = ssl_create_ticket_keyblock(ticket_key_path);
// this function just returns a keyblock
+ } else
--- End diff --
hmm strange.. clang-format is not doing that for me. I will do that manually
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
