Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1000#discussion_r78414549
--- Diff: proxy/http/HttpSessionManager.cc ---
@@ -98,7 +113,10 @@ ServerSessionPool::acquireSession(sockaddr const *addr,
INK_MD5 const &hostname_
// Otherwise we need to scan further matches to match the host name as
well.
// Note we don't have to check the port because it's checked as part
of the IP address key.
if (TS_SERVER_SESSION_SHARING_MATCH_IP != match_style) {
- while (loc && loc->hostname_hash != hostname_hash) {
+ while (loc) {
+ if (loc->hostname_hash == hostname_hash && match_sni(sm,
loc->get_netvc())) {
--- End diff --
I don't think this is the right approach. ``match_sni`` should do exactly
what it's name claims and we should check in the caller whether we are looking
for a TLS session. I think that having ``match_sni`` make assumptions about the
match is spooky action at a distance that makes this harder to understand than
is necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
