Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/887#discussion_r78429115
--- Diff: mgmt/RecordsConfig.cc ---
@@ -67,29 +67,29 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG, "proxy.config.alarm_email", RECD_STRING, TS_PKGSYSUSER,
RECU_DYNAMIC, RR_NULL, RECC_STR, ".*", RECA_NULL}
,
- {RECT_CONFIG, "proxy.config.syslog_facility", RECD_STRING, "LOG_DAEMON",
RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ {RECT_CONFIG, "proxy.config.syslog_facility", RECD_STRING, "LOG_DAEMON",
RECU_RESTART_TS, RR_NULL, RECC_STR, ".*", RECA_NULL}
,
//# Negative core limit means max out limit
- {RECT_CONFIG, "proxy.config.core_limit", RECD_INT, "-1", RECU_NULL,
RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ {RECT_CONFIG, "proxy.config.core_limit", RECD_INT, "-1",
RECU_RESTART_TS, RR_NULL, RECC_NULL, NULL, RECA_NULL}
--- End diff --
This should be ``RECU_DYNAMIC`` since we register an update callback when
it changes. It's not obvious that this actually works, since we might not have
privilege at the time we update. If you could test, that would be great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
