[
https://issues.apache.org/jira/browse/TS-4480?focusedWorklogId=28950&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28950
]
ASF GitHub Bot logged work on TS-4480:
--------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/16 15:57
Start Date: 13/Sep/16 15:57
Worklog Time Spent: 10m
Work Description: Github user SolidWallOfCode commented on a diff in the
pull request:
https://github.com/apache/trafficserver/pull/992#discussion_r78589196
--- Diff: iocore/net/test_certlookup.cc ---
@@ -88,7 +88,7 @@ REGRESSION_TEST(SSLCertificateLookup)(RegressionTest *t,
int /* atype ATS_UNUSED
// Basic hostname cases.
box.check(lookup.find("www.foo.com")->ctx == foo, "host lookup for
www.foo.com");
- box.check(lookup.find("www.bar.com")->ctx == all_com, "host lookup for
www.bar.com");
+ box.check(lookup.find("www.bar.com") == NULL, "www.bar.com won't match
*.com because we only match one level");
--- End diff --
Perhaps add some case bending to check that as well. Or is that a different
bug?
```
box.check(lookup.find("B.WilD.cOm")->ctx == wild, "wildcard lookup for
B.WilD.cOm");
```
Issue Time Tracking
-------------------
Worklog Id: (was: 28950)
Time Spent: 1h 40m (was: 1.5h)
> Wildcards in certificates should only match one level
> -----------------------------------------------------
>
> Key: TS-4480
> URL: https://issues.apache.org/jira/browse/TS-4480
> Project: Traffic Server
> Issue Type: Bug
> Components: Core, SSL
> Reporter: Michael Sokolnicki
> Assignee: Susan Hinrichs
> Fix For: 7.0.0
>
> Attachments: current_patch.diff
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> According to RFC 6125 section 6.4.3:
> {quote}
> If the wildcard character is the only character of the left-most label in the
> presented identifier, the client SHOULD NOT compare against anything but the
> left-most label of the reference identifier (e.g., *.example.com would match
> foo.example.com but not bar.foo.example.com or example.com).
> {quote}
> In the current implementation, certificates are searched for in a trie, and
> the longest match is returned, but there is no check if that match complies
> with the above rule. This causes invalid certs to be returned and SLL errors
> in the browser (in Firefox, we get SSL_ERROR_BAD_CERT_DOMAIN).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
