Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1013#discussion_r78638850
--- Diff: iocore/net/SSLUtils.cc ---
@@ -1629,7 +1629,8 @@ SSLInitServerContext(const SSLConfigParams *params,
const ssl_user_config *sslMu
}
if (!sslMultCertSettings->cert) {
- if (sslMultCertSettings->opt != SSLCertContext::OPT_TUNNEL) {
+ // There must be a certificate specified unless the tunnel action is
set, or this is the default case
+ if (sslMultCertSettings->opt != SSLCertContext::OPT_TUNNEL &&
strcmp(sslMultCertSettings->addr, "*") != 0) {
--- End diff --
In this case could "*" be the default destination configured by the
operator? Is that required to have a certificate?
Maybe this validation should be done after parsing a config file entry?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
