[
https://issues.apache.org/jira/browse/TS-4845?focusedWorklogId=29006&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29006
]
ASF GitHub Bot logged work on TS-4845:
--------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/16 21:45
Start Date: 13/Sep/16 21:45
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1015#discussion_r78650646
--- Diff: plugins/experimental/url_sig/url_sig.c ---
@@ -561,7 +561,9 @@ TSRemapDoRemap(void *ih, TSHttpTxn txnp,
TSRemapRequestInfo *rri)
/* ********* Allow ********* */
allow:
- app_qry = getAppQueryString(query, strlen(query));
+ if (query != NULL) {
+ app_qry = getAppQueryString(query, strlen(query));
+ }
--- End diff --
So this is the case where the exclusion regex was matched so it is ok to
not have a query string?
Issue Time Tracking
-------------------
Worklog Id: (was: 29006)
Time Spent: 1h 10m (was: 1h)
> NULL dereference in url_sig
> ---------------------------
>
> Key: TS-4845
> URL: https://issues.apache.org/jira/browse/TS-4845
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
> Reporter: James Peach
> Assignee: John Rushford
> Fix For: 7.1.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Seen in the static analyzer:
> {noformat}
> Making all in url_sig
> CC url_sig.lo
> url_sig.c:564:38: warning: Null pointer argument in call to string length
> function
> app_qry = getAppQueryString(query, strlen(query));
> ^~~~~~~~~~~~~
> 1 warning generated.
> {noformat}
> If there is no query string you can still do {{goto allow}}, but it looks
> like the code assumes missing query string will always {{goto deny}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
