[
https://issues.apache.org/jira/browse/TS-4641?focusedWorklogId=29024&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29024
]
ASF GitHub Bot logged work on TS-4641:
--------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/16 23:48
Start Date: 13/Sep/16 23:48
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1004#discussion_r78665705
--- Diff: doc/admin-guide/files/records.config.en.rst ---
@@ -2510,12 +2510,15 @@ HostDB
The filename to persist hostdb to on disk.
-.. ts:cv:: CONFIG proxy.config.cache.hostdb.sync_frequency INT 120
+.. ts:cv:: CONFIG proxy.config.cache.hostdb.sync_frequency INT 0
- Set the frequency (in seconds) to sync hostdb to disk.
+ Set the frequency (in seconds) to sync hostdb to disk. The default ``0``
+ turns off HostDB disk writing completely, to enable this set this value
to
--- End diff --
Make this into 2 sentences. It doesn't quite make sense.
Issue Time Tracking
-------------------
Worklog Id: (was: 29024)
Time Spent: 50m (was: 40m)
> Change default for proxy.config.cache.hostdb.sync_frequency
> -----------------------------------------------------------
>
> Key: TS-4641
> URL: https://issues.apache.org/jira/browse/TS-4641
> Project: Traffic Server
> Issue Type: Improvement
> Components: Configuration, Documentation, HostDB
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Labels: incompatible
> Fix For: 7.0.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> I'd like to propose that we change this setting, to 0, which means disable
> HostDB Synchronization. This is an incompatible change, but nonetheless a
> step in the right direction away from persistent HostDB storage. People can
> of course still enable it.
> {code}
> diff --git a/mgmt/RecordsConfig.cc b/mgmt/RecordsConfig.cc
> index ed71b5c..7a7e1c7 100644
> --- a/mgmt/RecordsConfig.cc
> +++ b/mgmt/RecordsConfig.cc
> @@ -1078,7 +1078,7 @@ static const RecordElement RecordsConfig[] =
> {RECT_CONFIG, "proxy.config.hostdb.timed_round_robin", RECD_INT, "0",
> RECU_DYNAMIC, RR_NULL, RECC_NULL, NULL, RECA_NULL}
> ,
> // # how often should the hostdb be synced (seconds)
> - {RECT_CONFIG, "proxy.config.cache.hostdb.sync_frequency", RECD_INT, "120",
> RECU_DYNAMIC, RR_NULL, RECC_NULL, NULL, RECA_NULL}
> + {RECT_CONFIG, "proxy.config.cache.hostdb.sync_frequency", RECD_INT, "0",
> RECU_DYNAMIC, RR_NULL, RECC_NULL, NULL, RECA_NULL}
> ,
> {RECT_CONFIG, "proxy.config.hostdb.host_file.path", RECD_STRING, NULL,
> RECU_DYNAMIC, RR_NULL, RECC_NULL, NULL, RECA_NULL}
> ,
> {code}
> Note that changing it to 0, or changing it from 0 to something else,
> requires restart. It's only "dynamic" if it it's not 0 (which turns off the
> sync cont).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
