[
https://issues.apache.org/jira/browse/TS-4864?focusedWorklogId=29080&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29080
]
ASF GitHub Bot logged work on TS-4864:
--------------------------------------
Author: ASF GitHub Bot
Created on: 14/Sep/16 21:01
Start Date: 14/Sep/16 21:01
Worklog Time Spent: 10m
Work Description: GitHub user ngara opened a pull request:
https://github.com/apache/trafficserver/pull/1021
TS-4864 CID 1362769 - when pthread_create fails, ink_abort instead of…
… returning 0, and remove dead code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ngara/trafficserver TS-4864
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1021.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1021
----
commit 8d0bdadecda7427c3ebbc03e074f7ee22e025aa9
Author: Nathan Garabedian <[email protected]>
Date: 2016-09-14T20:59:23Z
TS-4864 CID 1362769 - when pthread_create fails, ink_abort instead of
returning 0, and remove dead code
----
Issue Time Tracking
-------------------
Worklog Id: (was: 29080)
Time Spent: 10m
Remaining Estimate: 0h
> CID 1362769: Control flow issues (DEADCODE) in ink_thread.h
> -------------------------------------------------------------
>
> Key: TS-4864
> URL: https://issues.apache.org/jira/browse/TS-4864
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Reporter: Leif Hedstrom
> Assignee: Nathan Garabedian
> Labels: Coverity
> Fix For: 7.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Filing this just in case, but maybe Nathan's fixes around this is where to go
> ?
> {code}
> *** CID 1362769: Control flow issues (DEADCODE)
> /lib/ts/ink_thread.h: 160 in ink_thread_create(void *(*)(void *), void *,
> int, unsigned long, void *)()
> 154 pthread_attr_destroy(&attr);
> 155
> 156 /**
> 157 * Fix for INKqa10118.
> 158 * If the thread has not been created successfully return 0.
> 159 */
> CID 1362769: Control flow issues (DEADCODE)
> Execution cannot reach the expression "0UL" inside this statement: "return
> ret ? 0UL : t;".
> 160 return ret ? (ink_thread)0 : t;
> 161 }
> 162
> 163 static inline void
> 164 ink_thread_cancel(ink_thread who)
> 165 {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
