[
https://issues.apache.org/jira/browse/TS-4871?focusedWorklogId=29134&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29134
]
ASF GitHub Bot logged work on TS-4871:
--------------------------------------
Author: ASF GitHub Bot
Created on: 15/Sep/16 17:00
Start Date: 15/Sep/16 17:00
Worklog Time Spent: 10m
Work Description: Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1023
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/812/ for details.
Issue Time Tracking
-------------------
Worklog Id: (was: 29134)
Time Spent: 20m (was: 10m)
> CID 1362796: Integer handling issues (NEGATIVE_RETURNS) in statistics plugin
> ------------------------------------------------------------------------------
>
> Key: TS-4871
> URL: https://issues.apache.org/jira/browse/TS-4871
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
> Reporter: Leif Hedstrom
> Assignee: James Peach
> Labels: coverity
> Fix For: 7.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {code}
> *** CID 1362796: Integer handling issues (NEGATIVE_RETURNS)
> /example/statistic/statistic.cc: 50 in TSPluginInit()
> 44
> 45 int id;
> 46 const char name[] = "example.statistic.now";
> 47
> 48 if (TSStatFindName(name, &id) == TS_ERROR) {
> 49 id = TSStatCreate(name, TS_RECORDDATATYPE_INT,
> TS_STAT_NON_PERSISTENT, TS_STAT_SYNC_SUM);
> CID 1362796: Integer handling issues (NEGATIVE_RETURNS)
> Variable "id" tests negative.
> 50 if (id == TS_ERROR) {
> 51 TSError("%s: failed to register '%s'", PLUGIN_NAME, name);
> 52 }
> 53 }
> 54
> 55 TSError("%s: %s registered with id %d", PLUGIN_NAME, name, id);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
