Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1022#discussion_r79086248
--- Diff: mgmt/RecordsConfig.cc ---
@@ -834,6 +860,61 @@ static const RecordElement RecordsConfig[] =
//##############################################################################
//#
+ //# Cluster Subsystem
+ //#
+
//##############################################################################
+ {RECT_CONFIG, "proxy.config.cluster.threads", RECD_INT, "1",
RECU_RESTART_TS, RR_NULL, RECC_INT, "[0-512]", RECA_NULL}
+ ,
+ {RECT_CONFIG, "proxy.config.cluster.cluster_port", RECD_INT, "8086",
RECU_RESTART_TS, RR_REQUIRED, RECC_NULL, NULL, RECA_NULL}
+ ,
+ {RECT_CONFIG, "proxy.config.cluster.cluster_configuration", RECD_STRING,
"cluster.config", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ ,
+ {RECT_CONFIG, "proxy.config.cluster.ethernet_interface", RECD_STRING,
TS_BUILD_DEFAULT_LOOPBACK_IFACE, RECU_RESTART_TS, RR_REQUIRED, RECC_STR,
"^[^[:space:]]*$", RECA_NULL}
+ ,
+ {RECT_CONFIG, "proxy.config.cluster.enable_monitor", RECD_INT, "0",
RECU_DYNAMIC, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ ,
+ {RECT_CONFIG, "proxy.config.cluster.monitor_interval_secs", RECD_INT,
"1", RECU_DYNAMIC, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ ,
+ {RECT_CONFIG, "proxy.config.cluster.send_buffer_size", RECD_INT,
"10485760", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ ,
+ {RECT_CONFIG, "proxy.config.cluster.receive_buffer_size", RECD_INT,
"10485760", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ ,
+ {RECT_CONFIG, "proxy.config.cluster.sock_option_flag", RECD_INT, "0x0",
RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ ,
+ {RECT_CONFIG, "proxy.config.cluster.sock_packet_mark", RECD_INT, "0x0",
RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ ,
+ {RECT_CONFIG, "proxy.config.cluster.sock_packet_tos", RECD_INT, "0x0",
RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ ,
+ {RECT_CONFIG, "proxy.config.cluster.rpc_cache_cluster", RECD_INT, "0",
RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ ,
+
+ //##################################################################
+ //# Cluster interconnect load monitoring configuration options.
+ //# Internal use only
+ //##################################################################
+ //# load monitor_enabled: -1 = compute only, 0 = disable, 1 = compute
and act
+ {RECT_CONFIG, "proxy.config.cluster.load_monitor_enabled", RECD_INT,
"1", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ ,
+ {RECT_CONFIG, "proxy.config.cluster.ping_send_interval_msecs", RECD_INT,
"100", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ ,
+ {RECT_CONFIG, "proxy.config.cluster.ping_response_buckets", RECD_INT,
"100", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ ,
+ {RECT_CONFIG, "proxy.config.cluster.msecs_per_ping_response_bucket",
RECD_INT, "50", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ ,
+ {RECT_CONFIG, "proxy.config.cluster.ping_latency_threshold_msecs",
RECD_INT, "500", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ ,
+ {RECT_CONFIG, "proxy.config.cluster.load_compute_interval_msecs",
RECD_INT, "5000", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ ,
+ {RECT_CONFIG, "proxy.config.cluster.periodic_timer_interval_msecs",
RECD_INT, "100", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ ,
+ {RECT_CONFIG, "proxy.config.cluster.ping_history_buf_length", RECD_INT,
"120", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ ,
+ {RECT_CONFIG, "proxy.config.cluster.cluster_load_clear_duration",
RECD_INT, "24", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ ,
+ {RECT_CONFIG, "proxy.config.cluster.cluster_load_exceed_duration",
RECD_INT, "4", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
+ ,
--- End diff --
There is a bunch of code that asserts on the existence. And the more we dig
into it the more you have to remove, ala #966. This broke `traffic_cop` and
`traffic_manager` without these configs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
