Github user jpeach commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/887#discussion_r79205196
  
    --- Diff: mgmt/FileManager.cc ---
    @@ -602,9 +600,9 @@ FileManager::WalkSnaps(ExpandingArray *snapList)
     {
       MFresult r;
     
    -  // The original code reset this->managedDir from 
proxy.config.snapshot_dir at this point. There doesn't appear to be
    -  // any need for that, since managedDir is always set in the constructor 
and should not be changed.
    -  ink_release_assert(this->managedDir != NULL);
    +  // Make sure managedDir is the latest from proxy.config.snapshot_dir.
    +  ats_scoped_str snapshotDir(RecConfigReadSnapshotDir());
    +  this->managedDir = snapshotDir;
    --- End diff --
    
    You'll need to reset managedDir to NULL after the call to ``WalkFiles`` so 
you don't leave it as a dangling pointer.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to