ASF GitHub Bot logged work on TS-2258:

                Author: ASF GitHub Bot
            Created on: 16/Sep/16 16:34
            Start Date: 16/Sep/16 16:34
    Worklog Time Spent: 10m 
      Work Description: Github user jpeach commented on a diff in the pull 

    --- Diff: mgmt/FileManager.cc ---
    @@ -602,9 +600,9 @@ FileManager::WalkSnaps(ExpandingArray *snapList)
       MFresult r;
    -  // The original code reset this->managedDir from 
proxy.config.snapshot_dir at this point. There doesn't appear to be
    -  // any need for that, since managedDir is always set in the constructor 
and should not be changed.
    -  ink_release_assert(this->managedDir != NULL);
    +  // Make sure managedDir is the latest from proxy.config.snapshot_dir.
    +  ats_scoped_str snapshotDir(RecConfigReadSnapshotDir());
    +  this->managedDir = snapshotDir;
    --- End diff --
    You'll need to reset managedDir to NULL after the call to ``WalkFiles`` so 
you don't leave it as a dangling pointer.

Issue Time Tracking

    Worklog Id:     (was: 29245)
    Time Spent: 6.5h  (was: 6h 20m)

> Verify that all fields are correct in RecordsConfig.cc
> ------------------------------------------------------
>                 Key: TS-2258
>                 URL: https://issues.apache.org/jira/browse/TS-2258
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Core
>            Reporter: Leif Hedstrom
>            Assignee: Jari Alhonen
>              Labels: newbie
>             Fix For: 7.1.0
>          Time Spent: 6.5h
>  Remaining Estimate: 0h
> We should go through every configuration in RecordsConfig.cc, and assure that 
> fields such as if it's dynamically reloadable or not, validation regexes etc. 
> are all set 100% correct.
> Once this file is accurate, and will be the one true authoritative source for 
> everything "configuration"; it can be used for command line help (e.g. 
> traffic_line can say if a config is reloadable), and we can even use it as a 
> source for the Sphinx documentation.
> A bonus would be to add a one-line helper line for each configuration in 
> RecordsConfig.cc. This can again be used for e.g. traffic_line, or for a new 
> type of tools to help managing configurations.

This message was sent by Atlassian JIRA

Reply via email to