[ 
https://issues.apache.org/jira/browse/TS-4880?focusedWorklogId=29294&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29294
 ]

ASF GitHub Bot logged work on TS-4880:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Sep/16 07:49
            Start Date: 19/Sep/16 07:49
    Worklog Time Spent: 10m 
      Work Description: GitHub user syucream opened a pull request:

    https://github.com/apache/trafficserver/pull/1034

    TS-4880: Fix missing missing utils::internal::initTransactionManagement() 
call

    https://issues.apache.org/jira/browse/TS-4880

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/syucream/trafficserver TS-4880

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1034.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1034
    
----
commit cced5de168e28e59013c6455c54fa2f7e65a3d78
Author: Ryo Okubo <syucream1...@gmail.com>
Date:   2016-09-19T07:47:12Z

    TS-4880: Fix missing missing utils::internal::initTransactionManagement() 
call

----


Issue Time Tracking
-------------------

            Worklog Id:     (was: 29294)
            Time Spent: 10m
    Remaining Estimate: 0h

> RemapPlugin class doesn't work correctly
> ----------------------------------------
>
>                 Key: TS-4880
>                 URL: https://issues.apache.org/jira/browse/TS-4880
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: CPP API
>            Reporter: Ryo Okubo
>            Assignee: Brian Geffon
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Current atscppapi::RemapPlugin has two issues. These seem to be caused by 
> missing utils::internal::initTransactionManagement() call.
> First, after TS-4555, plugins uses RemapPlugin class doesn't work because it 
> can't pass an assertion.
> {noformat}
> # my remap.config. It uses RemapPlugin, one of atscppapi examples.
> map / http://127.0.0.1:80/ @plugin=RemapPlugin.so
> {noformat}
> {noformat}
> $ lldb /path/to/traffic_server
> ...
> (lldb) r
> ...
> (lldb) bt
> ...
> * thread #7: tid = 0x3ce4eef, 0x00007fff886d0f06 
> libsystem_kernel.dylib`__pthread_kill + 10, name = '[ET_NET 4]', stop reason 
> = signal SIGABRT
>   * frame #0: 0x00007fff886d0f06 libsystem_kernel.dylib`__pthread_kill + 10
>     frame #1: 0x00007fff91d6b4ec libsystem_pthread.dylib`pthread_kill + 90
>     frame #2: 0x00007fff902b56df libsystem_c.dylib`abort + 129
>     frame #3: 0x0000000000039799 
> libtsutil.7.dylib`ink_abort(message_format="%s:%d: failed assertion `%s`") + 
> 361 at ink_error.cc:79
>     frame #4: 0x000000000003703f 
> libtsutil.7.dylib`::_ink_assert(expression="arg_idx >= 0 && arg_idx < 
> HTTP_SSN_TXN_MAX_USER_ARG", file="InkAPI.cc", line=5881) + 47 at 
> ink_assert.cc:37
>     frame #5: 0x00000001000446c3 
> traffic_server`::_TSReleaseAssert(text="arg_idx >= 0 && arg_idx < 
> HTTP_SSN_TXN_MAX_USER_ARG", file="InkAPI.cc", line=5881) + 35 at InkAPI.cc:396
>     frame #6: 0x0000000100054e0f 
> traffic_server`::TSHttpTxnArgGet(txnp=0x0000000005d6b200, arg_idx=-1) + 111 
> at InkAPI.cc:5881
>     frame #7: 0x000000000579bb9b 
> libatscppapi.7.dylib`atscppapi::utils::internal::getTransaction(ats_txn_handle=0x0000000005d6b200)
>  + 27 at utils_internal.cc:159
>     frame #8: 0x00000000057bba8c 
> libatscppapi.7.dylib`::TSRemapDoRemap(ih=0x0000000000759fe0, 
> rh=0x0000000005d6b200, rri=0x000070000058df08) + 108 at RemapPlugin.cc:35
>     frame #9: 0x00000001001cb79e 
> traffic_server`RemapPlugins::run_plugin(this=0x000070000058e0e8, 
> plugin=0x0000000000759f90) + 350 at RemapPlugins.cc:75
>     frame #10: 0x00000001001cb9c3 
> traffic_server`RemapPlugins::run_single_remap(this=0x000070000058e0e8) + 435 
> at RemapPlugins.cc:111
> ...
> {noformat}
> Second, Remap Plugin remains an another issue if we simply revert 
> https://github.com/apache/trafficserver/commit/17fdb2fd7dc47d09f8c8d7f9b6ff27b035c00d85.
>  Objects of atscppapi::Transaction is created correctly at utils_internal.cc, 
> but its destructor is never called.
> {noformat}
> # Revert and rebuild ATS
> $ git revert 17fdb2fd7dc47d09f8c8d7f9b6ff27b035c00d85 --no-commit
> ...
> $ make && make install
> {noformat}
> {noformat}
> $ lldb /path/to/traffic_server
> ...
> (lldb) r
> ...
> # It can pass the assertion! but ...
> (lldb) b -M ~Transaction
> (lldb) r
> # atscppapi::Transaction::~Transaction() is called.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to