Github user jpeach commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1033#discussion_r79422164
  
    --- Diff: iocore/net/UnixNetVConnection.cc ---
    @@ -1273,14 +1273,21 @@ UnixNetVConnection::connectUp(EThread *t, int fd)
         con.is_bound     = true;
       }
     
    +  if (check_emergency_throttle(con)) {
    +    // `con' could be closed if there is hyper emergency
    +    if (con.fd == NO_FD) {
    +      NET_SUM_GLOBAL_DYN_STAT(net_connections_currently_open_stat, -1);
    --- End diff --
    
    Please comment here that we need to decrement the stat because 
``close_UnixNetVConnection`` only decrements with a valid connection descriptor.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to