[
https://issues.apache.org/jira/browse/TS-4866?focusedWorklogId=29401&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29401
]
ASF GitHub Bot logged work on TS-4866:
--------------------------------------
Author: ASF GitHub Bot
Created on: 20/Sep/16 15:08
Start Date: 20/Sep/16 15:08
Worklog Time Spent: 10m
Work Description: Github user PSUdaemon commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1035#discussion_r79634032
--- Diff: cmd/traffic_cop/traffic_cop.cc ---
@@ -651,6 +661,26 @@ config_reload_records()
config_read_int("proxy.config.cluster.rsport", &rs_port, true);
config_read_int("proxy.config.cop.init_sleep_time", &init_sleep_time,
true);
+ config_read_int("proxy.config.cop.active_health_checks", &tmp, true);
+ // 0 == No servers are killed
+ // 1 == Only traffic_manager can be killed on failure
+ // 2 == Only traffic_server can be killed on failure
+ // 3 == Any failing healthchecks can cause restarts (default)
+ switch (tmp) {
+ case 0:
+ active_health_checks = COP_KILL_NONE;
+ break;
+ case 1:
+ active_health_checks = COP_KILL_MANAGER;
+ break;
+ case 2:
+ active_health_checks = COP_KILL_SERVER;
+ break;
+ default:
+ active_health_checks = COP_KILL_SERVER | COP_KILL_MANAGER;
+ break;
+ }
+
--- End diff --
What do you think about skipping `tmp` and just saying something like:
```c++
config_read_int("proxy.config.cop.active_health_checks",
&active_health_checks, true);
if ((active_health_checks < 0) || (active_health_checks > 3)) {
active_health_checks = COP_KILL_SERVER | COP_KILL_MANAGER;
}
```
Issue Time Tracking
-------------------
Worklog Id: (was: 29401)
Time Spent: 40m (was: 0.5h)
> Remove traffic_cop health checking.
> -----------------------------------
>
> Key: TS-4866
> URL: https://issues.apache.org/jira/browse/TS-4866
> Project: Traffic Server
> Issue Type: Bug
> Components: Cop
> Affects Versions: 7.0.0
> Reporter: James Peach
> Assignee: Leif Hedstrom
> Fix For: 7.1.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> There is a school of thought that {{traffic_cop}} health checking causes more
> problems that in solves. Consider whether we should eliminate health checking
> from {{traffic_cop}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
