ASF GitHub Bot logged work on TS-4612:

                Author: ASF GitHub Bot
            Created on: 22/Sep/16 17:54
            Start Date: 22/Sep/16 17:54
    Worklog Time Spent: 10m 
      Work Description: Github user jpeach commented on the issue:

    @oknet would you mind revising the commit subject and descripton?
    TS-4612: Optimize InactivityCop.
    Longer description here. Capture the important points from this PR and from 
the Jira explanation.

Issue Time Tracking

    Worklog Id:     (was: 29514)
    Time Spent: 4.5h  (was: 4h 20m)

> Proposal: InactivityCop Optimize
> --------------------------------
>                 Key: TS-4612
>                 URL: https://issues.apache.org/jira/browse/TS-4612
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Core, Network
>            Reporter: Oknet Xu
>             Fix For: sometime
>          Time Spent: 4.5h
>  Remaining Estimate: 0h
> By review the processing of InactivityCop::check_inactivity():
> 1. get all local vc from open_list
> 2. put them into cop_list
> 3. check every vc in cop_list if it is already timeouted
> 4. callback vc->handleEvent to close vc if it is timeout
> InactivityCop and NetHandler share one mutex.
> InactivityCop runs every second, NetHandler runs every 10ms, that means 
> Nethandler runs 100 times until next InactivityCop runs.
> if one vc has read/write in a Nethandler call, it is won't be timeout in the 
> next InactivityCop run.
> Thus, if the vc has read/write in Nethandler, we move it out of cop-list then 
> the InactivityCop runs would get better performace.

This message was sent by Atlassian JIRA

Reply via email to