Github user PSUdaemon commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1041#discussion_r80123170
  
    --- Diff: proxy/ParentConsistentHash.cc ---
    @@ -61,22 +61,22 @@ ParentConsistentHash::~ParentConsistentHash()
     uint64_t
     ParentConsistentHash::getPathHash(HttpRequestData *hrdata, ATSHash64 *h)
     {
    -  const char *tmp = NULL;
    +  const char *url_string_ref = NULL;
       int len;
       URL *url = hrdata->hdr->url_get();
     
       // Use over-ride URL from HttpTransact::State's 
cache_info.parent_selection_url, if present.
       URL *ps_url = NULL;
    -  Debug("parent_select", "hrdata->cache_info_parent_selection_url = %p", 
hrdata->cache_info_parent_selection_url);
    +  // Debug("parent_select", "hrdata->cache_info_parent_selection_url = 
%p", hrdata->cache_info_parent_selection_url);
    --- End diff --
    
    We shouldn't be commenting out code. We have the history in git. This line 
should be totally removed or stay uncommented.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to