[ 
https://issues.apache.org/jira/browse/TS-4887?focusedWorklogId=29529&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29529
 ]

ASF GitHub Bot logged work on TS-4887:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Sep/16 19:59
            Start Date: 22/Sep/16 19:59
    Worklog Time Spent: 10m 
      Work Description: Github user PSUdaemon commented on a diff in the pull 
request:

    https://github.com/apache/trafficserver/pull/1041#discussion_r80123170
  
    --- Diff: proxy/ParentConsistentHash.cc ---
    @@ -61,22 +61,22 @@ ParentConsistentHash::~ParentConsistentHash()
     uint64_t
     ParentConsistentHash::getPathHash(HttpRequestData *hrdata, ATSHash64 *h)
     {
    -  const char *tmp = NULL;
    +  const char *url_string_ref = NULL;
       int len;
       URL *url = hrdata->hdr->url_get();
     
       // Use over-ride URL from HttpTransact::State's 
cache_info.parent_selection_url, if present.
       URL *ps_url = NULL;
    -  Debug("parent_select", "hrdata->cache_info_parent_selection_url = %p", 
hrdata->cache_info_parent_selection_url);
    +  // Debug("parent_select", "hrdata->cache_info_parent_selection_url = 
%p", hrdata->cache_info_parent_selection_url);
    --- End diff --
    
    We shouldn't be commenting out code. We have the history in git. This line 
should be totally removed or stay uncommented.


Issue Time Tracking
-------------------

    Worklog Id:     (was: 29529)
    Time Spent: 20m  (was: 10m)

> Clean up Parent Selection URL feature.
> --------------------------------------
>
>                 Key: TS-4887
>                 URL: https://issues.apache.org/jira/browse/TS-4887
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Parent Proxy
>            Reporter: Peter Chou
>            Assignee: Peter Chou
>             Fix For: 7.1.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> * Remove references to 'maxdirs' and 'fname' from the TS API manual page.
> * Rename the "tmp" variable  in ParentConsistentHash::getPathHash().
> * Clean up debug messages (remove excessive pointer value reporting).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to