[ 
https://issues.apache.org/jira/browse/TS-4882?focusedWorklogId=29575&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29575
 ]

ASF GitHub Bot logged work on TS-4882:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Sep/16 02:33
            Start Date: 23/Sep/16 02:33
    Worklog Time Spent: 10m 
      Work Description: Github user SolidWallOfCode commented on a diff in the 
pull request:

    https://github.com/apache/trafficserver/pull/1036#discussion_r80173011
  
    --- Diff: iocore/net/UnixNetVConnection.cc ---
    @@ -990,7 +991,28 @@ UnixNetVConnection::load_buffer_and_write(int64_t 
towrite, MIOBufferAccessor &bu
     
         ink_assert(niov > 0);
         ink_assert(niov <= countof(tiovec));
    -    r = socketManager.writev(con.fd, &tiovec[0], niov);
    +
    +#if DEBUG && (TCP_FASTOPEN == 0)
    --- End diff --
    
    `ink_assert` is only in debug mode, so that check is not useful. The other 
check should be blended in, e.g.
    ```
    ink_assert(TCP_FASTOPEN != 0 || ! this->options.f_tcp_fastopen);
    ```


Issue Time Tracking
-------------------

    Worklog Id:     (was: 29575)
    Time Spent: 3.5h  (was: 3h 20m)

> TCP Fast Open support for SSL server sessions.
> ----------------------------------------------
>
>                 Key: TS-4882
>                 URL: https://issues.apache.org/jira/browse/TS-4882
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Core, SSL
>            Reporter: James Peach
>            Assignee: James Peach
>             Fix For: 7.1.0
>
>          Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Add support for using TCP Fast Open on TLS server sessions. This is mainly 
> interesting for CONNECT tunnels where we can't use long running persistent 
> sessions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to