Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1048#discussion_r80528860
--- Diff: iocore/eventsystem/I_Thread.h ---
@@ -145,8 +145,7 @@ class Thread
Thread &operator=(const Thread &);
public:
- ink_thread start(const char *name, size_t stacksize = DEFAULT_STACKSIZE,
ThreadFunction f = NULL, void *a = NULL,
- void *stack = NULL);
+ ink_thread start(const char *name, size_t stacksize, ThreadFunction f,
void *a, void *stack);
--- End diff --
Consider removing ``ThreadFunction`` and making ``Thread::execute()`` pure
virtual since ``ThreadFunction`` is never used anywhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
