[
https://issues.apache.org/jira/browse/TS-4883?focusedWorklogId=29751&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29751
]
ASF GitHub Bot logged work on TS-4883:
--------------------------------------
Author: ASF GitHub Bot
Created on: 26/Sep/16 17:36
Start Date: 26/Sep/16 17:36
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1048#discussion_r80528860
--- Diff: iocore/eventsystem/I_Thread.h ---
@@ -145,8 +145,7 @@ class Thread
Thread &operator=(const Thread &);
public:
- ink_thread start(const char *name, size_t stacksize = DEFAULT_STACKSIZE,
ThreadFunction f = NULL, void *a = NULL,
- void *stack = NULL);
+ ink_thread start(const char *name, size_t stacksize, ThreadFunction f,
void *a, void *stack);
--- End diff --
Consider removing ``ThreadFunction`` and making ``Thread::execute()`` pure
virtual since ``ThreadFunction`` is never used anywhere.
Issue Time Tracking
-------------------
Worklog Id: (was: 29751)
Time Spent: 1h 40m (was: 1.5h)
> Argument mismatch of the Thread::start call in EventProcessor::start
> --------------------------------------------------------------------
>
> Key: TS-4883
> URL: https://issues.apache.org/jira/browse/TS-4883
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Reporter: Masato Gosui
> Fix For: 7.1.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> EventProcessor::start() calls Thread::start(), which takes 5 arguments:
> # name
> # stacksize
> # f(function pointer to be executed by the thread)
> # a(argument for f)
> # stack(pointer to stack used by the thread)
> However the call to Thread::start() takes the pointer to stack as 4th
> argument.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
