Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1051#discussion_r80715731
--- Diff: lib/ts/ink_args.cc ---
@@ -320,7 +320,7 @@ usage(const ArgumentDescription *argument_descriptions,
unsigned n_argument_desc
case 'f':
case 'F':
if (argument_descriptions[i].location) {
- fprintf(stderr, " %-9s", *(int *)argument_descriptions[i].location
? "true " : "false");
+ fprintf(stderr, " %-9s", *(bool
*)argument_descriptions[i].location ? "true " : "false");
--- End diff --
Every other place that has a flag argument uses an ``int`` for the flag.
This should be consistent, so if you change the flag type, you need to change
it everywhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
