[
https://issues.apache.org/jira/browse/TS-3743?focusedWorklogId=29835&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29835
]
ASF GitHub Bot logged work on TS-3743:
--------------------------------------
Author: ASF GitHub Bot
Created on: 27/Sep/16 18:58
Start Date: 27/Sep/16 18:58
Worklog Time Spent: 10m
Work Description: Github user PSUdaemon commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1006#discussion_r80768787
--- Diff: proxy/http/HttpSM.cc ---
@@ -6254,7 +6258,11 @@ HttpSM::setup_internal_transfer(HttpSMHandler
handler_arg)
tunnel.add_consumer(ua_entry->vc, HTTP_TUNNEL_STATIC_PRODUCER,
&HttpSM::tunnel_handler_ua, HT_HTTP_CLIENT, "user agent");
ua_entry->in_tunnel = true;
- tunnel.tunnel_run(p);
+
+ // Only actually try to do this on live sessions.
+ if (ua_session->m_active) {
--- End diff --
Can we become active between line 6172 and line 6263?
Issue Time Tracking
-------------------
Worklog Id: (was: 29835)
Time Spent: 1h 10m (was: 1h)
> Crash Under Heavy Load and Sending Plugin Error Page
> ----------------------------------------------------
>
> Key: TS-3743
> URL: https://issues.apache.org/jira/browse/TS-3743
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Reporter: Sam Baskinger
> Assignee: Nick Kew
> Labels: review
> Fix For: 7.1.0
>
> Attachments: TS-3743.patch, stacktrace.txt
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> One of the tests done on the [IronBee|http://www.ironbee.com] plugin for
> TrafficServer is to send a [OWASP
> Zap|https://www.owasp.org/index.php/OWASP_Zed_Attack_Proxy_Project] scan
> through the proxy at a DokuWiki server. When this is done TrafficServer will
> crash. The crash is not always at the same point in the scan, but is always
> when IronBee is generating a custom block page. We've reviewed IronBee and
> cannot find anything it is doing to provoke the crash.
> The crash is always in {{HttpTunnel::producer_run
> (this=this@entry=0xaf6021c8, p=p@entry=0xaf6022f8)}} and in all cases
> {{c->vc}} is invalid.
> Our investigations correlated the crash with HttpSM's
> {{ua_session->m_active}} being false. More specifically we suspect that
> {{Http::SM::setup_internal_transfer()}} starts with {{ua_session->m_active}}
> as true and then closes it -- setting {{ua_session->m_active}} to false --
> before {{tunnel.tunnel_run(p)}} is called at the end of the function.
> Please refer to two attachments. The first is a copy of the stack trace we've
> been working off of. Every crash has a remarkably similar call stack. The
> second attachment is a patch that is working in our labs.
> This crash also appears in the TrafficServer 4.x code, and the same patch
> seems to resolve it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
