Github user masaori335 commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1052#discussion_r80833386
  
    --- Diff: proxy/http2/Http2ConnectionState.cc ---
    @@ -1174,9 +1174,9 @@ Http2ConnectionState::send_a_data_frame(Http2Stream 
*stream, size_t &payload_len
     void
     Http2ConnectionState::send_data_frames(Http2Stream *stream)
     {
    -  if (stream->get_state() == HTTP2_STREAM_STATE_CLOSED || 
stream->get_state() == HTTP2_STREAM_STATE_HALF_CLOSED_LOCAL) {
    +/*  if (stream->get_state() == HTTP2_STREAM_STATE_CLOSED || 
stream->get_state() == HTTP2_STREAM_STATE_HALF_CLOSED_LOCAL) {
         return;
    -  }
    +  } */
    --- End diff --
    
    The motivation of this check is to respect HTTP/2 spec. RFC 7540 says below
    
    > An endpoint MUST NOT send frames other than PRIORITY on a closed stream.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to