[ 
https://issues.apache.org/jira/browse/TS-4813?focusedWorklogId=29892&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29892
 ]

ASF GitHub Bot logged work on TS-4813:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Sep/16 11:05
            Start Date: 28/Sep/16 11:05
    Worklog Time Spent: 10m 
      Work Description: Github user shinrich commented on a diff in the pull 
request:

    https://github.com/apache/trafficserver/pull/1052#discussion_r80891687
  
    --- Diff: proxy/http2/Http2ConnectionState.cc ---
    @@ -1174,9 +1174,9 @@ Http2ConnectionState::send_a_data_frame(Http2Stream 
*stream, size_t &payload_len
     void
     Http2ConnectionState::send_data_frames(Http2Stream *stream)
     {
    -  if (stream->get_state() == HTTP2_STREAM_STATE_CLOSED || 
stream->get_state() == HTTP2_STREAM_STATE_HALF_CLOSED_LOCAL) {
    +/*  if (stream->get_state() == HTTP2_STREAM_STATE_CLOSED || 
stream->get_state() == HTTP2_STREAM_STATE_HALF_CLOSED_LOCAL) {
         return;
    -  }
    +  } */
    --- End diff --
    
    Ok, I'll try adjusting the fix to just call the delete stream cleanup if 
this is called when already closed.


Issue Time Tracking
-------------------

    Worklog Id:     (was: 29892)
    Time Spent: 1h 20m  (was: 1h 10m)

> HttpTunnel.cc:1215: failed assertion `p->alive == true || event == 
> HTTP_TUNNEL_EVENT_PRECOMPLETE ...
> ----------------------------------------------------------------------------------------------------
>
>                 Key: TS-4813
>                 URL: https://issues.apache.org/jira/browse/TS-4813
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Network
>            Reporter: Leif Hedstrom
>            Priority: Blocker
>              Labels: crash
>             Fix For: 7.1.0
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Seeing this with current (as of right now) master, on docs.trafficserver:
> {code}
> FATAL: HttpTunnel.cc:1215: failed assertion `p->alive == true || event == 
> HTTP_TUNNEL_EVENT_PRECOMPLETE || event == VC_EVENT_EOS || 
> sm->enable_redirection || (p->self_consumer && p->self_consumer->alive == 
> true)`
> traffic_server: using root directory '/opt/ats'
> traffic_server: Aborted (Signal sent by tkill() 13188 99)
> traffic_server - STACK TRACE:
> /opt/ats/lib/libtsutil.so.7(signal_crash_handler(int, siginfo_t*, 
> void*)+0x18)[0x2b6d1031729e]
> /opt/ats/bin/traffic_server(crash_logger_invoke(int, siginfo_t*, 
> void*)+0x155)[0x534104]
> /lib64/libpthread.so.0(+0xf100)[0x2b6d1240f100]
> /lib64/libc.so.6(gsignal+0x37)[0x2b6d12d6e5f7]
> /lib64/libc.so.6(abort+0x148)[0x2b6d12d6fce8]
> /opt/ats/lib/libtsutil.so.7(ink_warning(char const*, ...)+0x0)[0x2b6d102f6f4d]
> /opt/ats/lib/libtsutil.so.7(+0x733a7)[0x2b6d102f13a7]
> /opt/ats/bin/traffic_server(HttpTunnel::producer_handler(int, 
> HttpTunnelProducer*)+0xd14)[0x768a12]
> /opt/ats/bin/traffic_server(HttpTunnel::main_handler(int, 
> void*)+0x13b)[0x76b6e1]
> /opt/ats/bin/traffic_server(Continuation::handleEvent(int, 
> void*)+0x149)[0x53a621]
> /opt/ats/bin/traffic_server(HttpSM::state_watch_for_client_abort(int, 
> void*)+0x9fe)[0x68c5e6]
> /opt/ats/bin/traffic_server(HttpSM::main_handler(int, void*)+0x58e)[0x69b7ec]
> /opt/ats/bin/traffic_server(Continuation::handleEvent(int, 
> void*)+0x149)[0x53a621]
> /opt/ats/bin/traffic_server(Http2Stream::main_event_handler(int, 
> void*)+0x59f)[0x79c1df]
> /opt/ats/bin/traffic_server(Continuation::handleEvent(int, 
> void*)+0x149)[0x53a621]
> /opt/ats/bin/traffic_server(EThread::process_event(Event*, 
> int)+0x2cf)[0xa809fb]
> /opt/ats/bin/traffic_server(EThread::execute()+0x671)[0xa8140f]
> /opt/ats/bin/traffic_server[0xa7f407]
> /lib64/libpthread.so.0(+0x7dc5)[0x2b6d12407dc5]
> /lib64/libc.so.6(clone+0x6d)[0x2b6d12e2fced]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to