Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1057#discussion_r80906705
--- Diff: lib/atscppapi/examples/websocket/WebSocket.h ---
@@ -38,6 +38,11 @@ using atscppapi::InterceptPlugin;
using atscppapi::Transaction;
using atscppapi::GlobalPlugin;
+namespace
+{
+GlobalPlugin *plugin;
+}
--- End diff --
That header file is only included for by this one plugin. I can move it
though. I'll also fix the coverity issues that just came out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
