[
https://issues.apache.org/jira/browse/TS-4903?focusedWorklogId=29940&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29940
]
ASF GitHub Bot logged work on TS-4903:
--------------------------------------
Author: ASF GitHub Bot
Created on: 28/Sep/16 22:41
Start Date: 28/Sep/16 22:41
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1061#discussion_r81033130
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -71,8 +71,8 @@ fastopen_bwrite(BIO *bio, const char *in, int insz)
NET_INCREMENT_DYN_STAT(net_fastopen_attempts_stat);
err = socketManager.sendto(bio->num, (void *)in, insz, MSG_FASTOPEN,
dst, ats_ip_size(dst));
- if (err < 0) {
- NET_INCREMENT_DYN_STAT(net_fastopen_failures_stat);
+ if (err > 0) {
--- End diff --
It is borderline. I changed it to ``>=`` to be consistent with the other
metric increment.
Issue Time Tracking
-------------------
Worklog Id: (was: 29940)
Time Spent: 50m (was: 40m)
> EISCONN errors when using TCP Fast Open.
> ----------------------------------------
>
> Key: TS-4903
> URL: https://issues.apache.org/jira/browse/TS-4903
> Project: Traffic Server
> Issue Type: Bug
> Reporter: James Peach
> Assignee: James Peach
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
