Github user calavera commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1062#discussion_r81247196
--- Diff: proxy/http2/Http2Stream.cc ---
@@ -356,8 +356,6 @@ Http2Stream::transaction_done()
if (closed) {
// Safe to initiate SSN_CLOSE if this is the last stream
- if (cross_thread_event)
- cross_thread_event->cancel();
// Schedule the destroy to occur after we unwind here. IF we call
directly, may delete with reference on the stack.
--- End diff --
If do_io_close set the event again, would it make sense to check if the
even is cancelled rather than removing this code? In our tests, this doesn't
happen, but I'm not familiar with the code to be sure it never happens.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
