Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1066#discussion_r81413339
--- Diff: proxy/http/HttpTransactHeaders.cc ---
@@ -812,26 +813,16 @@
HttpTransactHeaders::insert_via_header_in_response(HttpTransact::State *s, HTTPH
}
char *incoming_via = s->via_string;
- int scheme = s->next_hop_scheme;
+ ink_assert(s->state_machine);
--- End diff --
Looking at the code, it seems it's setup in the ::init(), and then never
unset / cleared? If so, do we even need this assert? I guess it doesn't hurt,
but I don't see us do this anywhere else.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
