GitHub user jacksontj opened a pull request:
https://github.com/apache/trafficserver/pull/1070
TS-4509 Add `outstanding_bytes` to VConnection
With this we can better check request retryability. This (in addition to
not releasing the sessions immediately on error) means that if the request is
retryable we can simply check if the number of bytes queued is the same as the
number of bytes we've asked to write. If these match, then we can be sure we
didn't send any ACKd packets-- meaning we are completely safe to retry.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jacksontj/trafficserver TS-3959
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1070.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1070
----
commit 760565954c2b7a9bb747d8e399a6b412b27466f0
Author: Thomas Jackson <[email protected]>
Date: 2016-10-03T15:16:28Z
TS-4509 Add `outstanding_bytes` to VConnection
With this we can better check request retryability. This (in addition to
not releasing the sessions immediately on error) means that if the request is
retryable we can simply check if the number of bytes queued is the same as the
number of bytes we've asked to write. If these match, then we can be sure we
didn't send any ACKd packets-- meaning we are completely safe to retry.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
