Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1070#discussion_r81578881
--- Diff: proxy/http/HttpTransact.cc ---
@@ -6536,14 +6536,23 @@ HttpTransact::is_request_valid(State *s, HTTPHdr
*incoming_request)
// In the general case once bytes have been sent on the wire the request
cannot be retried.
// The reason we cannot retry is that the rfc2616 does not make any
gaurantees about the
// retry-ability of a request. In fact in the reverse proxy case it is
quite common for GET
-// requests on the origin to fire tracking events etc. So, as a proxy once
we have sent bytes
-// on the wire to the server we cannot gaurantee that the request is safe
to redispatch to another server.
+// requests on the origin to fire tracking events etc. So, as a proxy once
bytes have been ACKd
+// to the server we cannot gaurantee that the request is safe to retry or
redispatch to another server.
+// This is destinction of "ACKd" vs "sent" is intended, and has reason. In
the case of a
+// new origin connection there is little difference, as the chance of a
RST between setup
+// and the first set of bytes is relatively small. This destinction is
more apparent in the
--- End diff --
s/destinction/distinction/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
