[
https://issues.apache.org/jira/browse/TS-4930?focusedWorklogId=30142&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30142
]
ASF GitHub Bot logged work on TS-4930:
--------------------------------------
Author: ASF GitHub Bot
Created on: 04/Oct/16 22:51
Start Date: 04/Oct/16 22:51
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1078#discussion_r81870634
--- Diff: proxy/hdrs/HdrTest.cc ---
@@ -522,6 +524,16 @@ HdrTest::test_mime()
return (failures_to_status("test_mime", 1));
}
+ // Test the (new) continuation line folding to be correct. This should
replace the
+ // \r\n with two spaces (so a total of three between "part1" and
"part2").
+ int length;
+ const char *continuation = hdr.value_get("continuation", 12, &length);
+
+ if ((13 != length) || strncmp(continuation, "part1 part2", 13) ||
strncmp(continuation + 5, " ", 3)) {
--- End diff --
This will be easier to debug if you separate each condition into a separate
failure.
Issue Time Tracking
-------------------
Worklog Id: (was: 30142)
Time Spent: 50m (was: 40m)
> Unfold request headers that are using obs continuations
> -------------------------------------------------------
>
> Key: TS-4930
> URL: https://issues.apache.org/jira/browse/TS-4930
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 7.1.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In RFC 7230, we have
> {code}
> Header fields that span multiple lines ("line folding") are
> deprecated. (Section 3.2.4)
> {code}
> Our recommendation is to unfold these into a single line for now, possibly
> later add an option to make such request generate 40x errors.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
