[
https://issues.apache.org/jira/browse/TS-4858?focusedWorklogId=30191&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30191
]
ASF GitHub Bot logged work on TS-4858:
--------------------------------------
Author: ASF GitHub Bot
Created on: 05/Oct/16 19:17
Start Date: 05/Oct/16 19:17
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1024#discussion_r82044347
--- Diff: iocore/net/P_SSLCertLookup.h ---
@@ -110,5 +109,5 @@ struct SSLCertLookup : public ConfigInfo {
void ticket_block_free(void *ptr);
ssl_ticket_key_block *ticket_block_alloc(unsigned count);
-
+ssl_ticket_key_block *ssl_create_ticket_key_block_buffer(char
*ticket_key_data, int ticket_key_len);
--- End diff --
Please use a consistent naming convention. We have``ticket_block_free()``,
``ticket_block_alloc()``, so consider ``ticket_block_create()`` or something.
Issue Time Tracking
-------------------
Worklog Id: (was: 30191)
Time Spent: 1.5h (was: 1h 20m)
> Global session ticket key block leaks.
> --------------------------------------
>
> Key: TS-4858
> URL: https://issues.apache.org/jira/browse/TS-4858
> Project: Traffic Server
> Issue Type: Bug
> Components: SSL
> Reporter: James Peach
> Assignee: Syeda Persia Aziz
> Fix For: 7.1.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> From source inspection, ``global_default_keyblock`` is always assigned so it
> will leak on configuration reload.
> Have not reproduced this since I wasn't able to get SSL config reload to work
> :-(
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
