GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/1083
TS-4938: Avoid crashes due to NULL vc dereferences.
While debugging the fix for TS-4813, I saw a crash due to a
ua_session->get_netvc() being null be being dereferenced anyway in
HttpTransact. In this PR I'm trying to be defensive in dealing with this.
Actually there was a straight up correctness issue with the
set_active/inactivity_timeout going through the ua_session->get_netvc() rather
than ua_session. The timeouts are handled differently for Http2 than for
Http1, so we really need to pass through the ProxyClientTransaction object.
The other cases, are pulling local/remote address/port information.
Eventually we should sink that into the ProxyClientTransaction layer too, but
for this PR, I'm just doing the NULL checks. Forward progress.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich/trafficserver ts-4938
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1083.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1083
----
commit 6c4fc39874be53051497975ffc47c5102c623ba1
Author: Susan Hinrichs <[email protected]>
Date: 2016-10-06T16:20:08Z
TS-4938: Avoid crashes due to NULL vc dereferences.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
