Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1083#discussion_r82613147
--- Diff: proxy/http/HttpTransact.cc ---
@@ -568,7 +568,10 @@ HttpTransact::BadRequest(State *s)
void
HttpTransact::HandleBlindTunnel(State *s)
{
- bool inbound_transparent_p =
s->state_machine->ua_session->get_netvc()->get_is_transparent();
+ NetVConnection *vc = s->state_machine->ua_session->get_netvc();
+ if (!vc)
+ return;
--- End diff --
I didn't see this one. After getting two or three crashes on
ua_session->get_netvc() indirections, I was systematically checking all of
them. I wasn't testing the blind tunnel case, so I wasn't exercising this one.
Probably won't be an issue here. I'll back this one out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
