Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1024#discussion_r82625741
--- Diff: iocore/net/SSLUtils.cc ---
@@ -2159,7 +2123,7 @@ ssl_callback_session_ticket(SSL *ssl, unsigned char
*keyname, unsigned char *iv,
ssl_ticket_key_block *keyblock = NULL;
if (cc == NULL || cc->keyblock == NULL) {
// Try the default
- keyblock = global_default_keyblock;
+ keyblock = params->default_global_keyblock;
--- End diff --
Not sure I'm following your used just once comment. The keyblock is used
only within this function. As long as we have acquired the SSLConfig, the
keyblock value it refers to will not disappear. It seems that in most cases,
the overlap on config reload will be at most one, but it could be multiple
safely as long as we have a referece to the SSLConfig before we start and hold
it the entire time we are using the keyblock value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
