[
https://issues.apache.org/jira/browse/TS-4952?focusedWorklogId=30394&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30394
]
ASF GitHub Bot logged work on TS-4952:
--------------------------------------
Author: ASF GitHub Bot
Created on: 11/Oct/16 18:25
Start Date: 11/Oct/16 18:25
Worklog Time Spent: 10m
Work Description: Github user PSUdaemon commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1091#discussion_r82857433
--- Diff: iocore/eventsystem/Thread.cc ---
@@ -44,7 +44,14 @@ Thread::Thread()
{
mutex = new_ProxyMutex();
MUTEX_TAKE_LOCK(mutex, (EThread *)this);
- mutex->nthread_holding = THREAD_MUTEX_THREAD_HOLDING;
+ mutex->nthread_holding += THREAD_MUTEX_THREAD_HOLDING;
+}
+
+Thread::~Thread()
+{
+ ink_release_assert(mutex->thread_holding == (EThread *)this);
+ mutex->nthread_holding -= THREAD_MUTEX_THREAD_HOLDING;
+ MUTEX_UNTAKE_LOCK(mutex, (EThread *)this);
--- End diff --
Does this mutex even exist afterwards? Is this to keep static analysis
happy?
Issue Time Tracking
-------------------
Worklog Id: (was: 30394)
Time Spent: 1h (was: 50m)
> Improve mutex error checking.
> -----------------------------
>
> Key: TS-4952
> URL: https://issues.apache.org/jira/browse/TS-4952
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Reporter: James Peach
> Time Spent: 1h
> Remaining Estimate: 0h
>
> If any {{ink_mutex}} operations fail, we just abort. Use {{ink_abort}} so
> that we can log an error if this happens.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
