Github user jpeach commented on a diff in the pull request:
    --- Diff: iocore/hostdb/ ---
    @@ -264,7 +272,20 @@ main()
       // printf("Sync return: %d\n", cache->sync_all());
       printf("TestRun: %d\n", ret);
    -  exit(ret);
    +  delete cache;
    +  return ret;
    +int main() {
    +  int ret = test();
    +  for (const auto item: ExampleStruct::items_freed) {
    +    printf("really freeing: %p\n", item);
    +    ::free(item);
    +  }
    +  ExampleStruct::items_freed.clear();
    --- End diff --
    Since this is a test, how about verifying that all the expected items were 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to