Thomas Jackson commented on TS-4960:

There is a fairly long chain of bugs around this-- so I'll attempt to dump as 
much context here as I can.

Originally we had an issue with internal transactions were getting stuck on 
inactivity timers because they'd get into a half-close state-- at the time 
plugin VC stuff didn't fire the appropriate events for the half-close state to 
ever end. Later (seemingly unrelated and unknown that they interact) TS-3777 
came around and added missing events from the pluginVC.

To [~jpe...@apache.org]'s point-- the plugin VCs shouldn't be treated any 
differently-- the original patch was to workaround the fact that they *where* 
different in the code, which seems to be fixed now with TS-3777. So, assuming 
pluginVCs now fire all the same events-- we *should* be able to remove the 
patch from TS-3404 

> Undo internal request tunnelling hacks
> --------------------------------------
>                 Key: TS-4960
>                 URL: https://issues.apache.org/jira/browse/TS-4960
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Core
>            Reporter: James Peach
> {noformat}
> proxy/http/HttpSM.cc:        is_eligible_post_request &= 
> !vc->get_is_internal_request();
> {noformat}
> {{HttpSM::tunnel_handler_ua}} does shenanigans based on whether this is an 
> internal transaction or not. This is a complete hack. Internal transactions 
> are no supposed to behave differently.
> AFAICT, this hack from  TS-3404 led to TS-3777, which led to TS-4924, which 
> makes it impossible for protocol plugins to use keepalive.

This message was sent by Atlassian JIRA

Reply via email to