[ 
https://issues.apache.org/jira/browse/TS-4961?focusedWorklogId=30512&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30512
 ]

ASF GitHub Bot logged work on TS-4961:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Oct/16 19:13
            Start Date: 12/Oct/16 19:13
    Worklog Time Spent: 10m 
      Work Description: GitHub user jpeach opened a pull request:

    https://github.com/apache/trafficserver/pull/1098

    TS-4961: Use default accept thread config for plugin accepts.

    Since TSPortDescriptorAccept and TSPluginDescriptorAccept don't have
    a way to specify the number of threads, pass -1 to make_net_accept()
    so that it uses the default from proxy.config.accept_threads.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jpeach/trafficserver fix/4961

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1098.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1098
    
----
commit 9b066f4c3f04b76df5e415d037611de09d85f4fc
Author: James Peach <jpe...@apache.org>
Date:   2016-10-12T19:06:15Z

    TS-4961: Use default accept thread config for plugin accepts.
    
    Since TSPortDescriptorAccept and TSPluginDescriptorAccept don't have
    a way to specify the number of threads, pass -1 to make_net_accept()
    so that it uses the default from proxy.config.accept_threads.

----


Issue Time Tracking
-------------------

            Worklog Id:     (was: 30512)
            Time Spent: 10m
    Remaining Estimate: 0h

> Plugin accept should use default thread counts.
> -----------------------------------------------
>
>                 Key: TS-4961
>                 URL: https://issues.apache.org/jira/browse/TS-4961
>             Project: Traffic Server
>          Issue Type: Bug
>            Reporter: James Peach
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {{TSPortDescriptorAccept}} and {{TSPluginDescriptorAccept}} both explicity 
> pass a 0 thread count to {{make_net_accept}}. Since there is no API for the 
> plugin to specify what is needed (unlike {{TSNetAccept}}), the principle of 
> least surprise would suggest we use the default config from 
> {{proxy.config.accept_threads}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to